Conversation
|
Having a Draft PR open to prepare the change is fine by me, but let's wait for fabric-chaincode-go to get completely settled and released before we bump the version in core fabric. |
7585310 to
06cbe2f
Compare
ba03229 to
6231b13
Compare
denyeart
left a comment
There was a problem hiding this comment.
This looks good... let's see if github makes us rebase given my recent update to go.mod.
Signed-off-by: Fedor Partanskiy <fedor.partanskiy@atme.com>
Signed-off-by: Fedor Partanskiy <fedor.partanskiy@atme.com>
|
Not a huge deal but we usually don't like to have multiple commits in a PR that supersede each other. I usually do |
6231b13 to
314b4e3
Compare
I didn't wait, I made a rebase. |
I can close, redo and open a new pr. |
|
Sorry I broke your PR :-) |
No, no, don't be sorry. You did the right thing. I don't like big changes myself. |
#5086