added to OSN new handler for update config of channel - #5244
Merged
Conversation
Contributor
Author
|
pr is very heavy and difficult, I will break it down into parts to make it easier and clearer. |
pfi79
force-pushed
the
add-osn-update
branch
3 times, most recently
from
July 21, 2025 13:49
e15c297 to
53cd268
Compare
pfi79
force-pushed
the
add-osn-update
branch
2 times, most recently
from
July 27, 2025 18:50
e4c5e3a to
4c21c9b
Compare
C0rWin
reviewed
Aug 7, 2025
| } | ||
|
|
||
| By(fmt.Sprintf("Rotating cert on leader %d", leader)) | ||
| time.Sleep(5 * time.Second) |
Contributor
There was a problem hiding this comment.
Please use Eventual with condition why are you waiting here instead of sleep.
C0rWin
reviewed
Aug 7, 2025
| By("Rotating certificates of other orderer nodes") | ||
| for i := range certificateRotations { | ||
| if i != leaderIndex { | ||
| time.Sleep(5 * time.Second) |
C0rWin
reviewed
Aug 7, 2025
| port := network.OrdererPort(o, nwo.ClusterPort) | ||
|
|
||
| By(fmt.Sprintf("Adding the future certificate of orderer node %d", i)) | ||
| time.Sleep(5 * time.Second) |
C0rWin
reviewed
Aug 7, 2025
| assertBlockReception(expectedBlockNumPerChannel[i*2], orderers, peer, network) | ||
|
|
||
| By("Removing the previous certificate of the old orderer") | ||
| time.Sleep(5 * time.Second) |
Contributor
There was a problem hiding this comment.
Same as above, please use Eventual
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
C0rWin
reviewed
Aug 12, 2025
Comment on lines
+232
to
+236
| go func() { | ||
| defer GinkgoRecover() | ||
| Update(n, orderer, channel, updateEnvelope) | ||
| close(ready) | ||
| }() |
Contributor
Author
There was a problem hiding this comment.
If the Update execution freezes "forever", Eventually will terminate the test earlier with an error.
C0rWin
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
peer channel updateinternally only accesses orderers.I think it's better to add this command to OSN.