Skip to content

feat: try to get manifest.json from release first #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Windol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: try to get manifest.json from release first #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions internal/core/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,22 @@ func GetManifestForRelease(version string) (*types.VersionManifest, error) {

func getManifest(version string) (*types.VersionManifest, error) {
manifest := &types.VersionManifest{}
if err := request("GET", fmt.Sprintf("https://raw.githubusercontent.com/hyperledger/firefly/%s/manifest.json", version), nil, &manifest); err != nil {
return nil, err
manifestURLs := []string{
fmt.Sprintf("https://github.com/hyperledger/firefly/releases/download/%s/manifest.json", version),
fmt.Sprintf("https://raw.githubusercontent.com/hyperledger/firefly/%s/manifest.json", version),
}
return manifest, nil
var lastErr error

for _, url := range manifestURLs {
manifest = &types.VersionManifest{}
if err := request("GET", url, nil, &manifest); err == nil {
return manifest, nil
} else {
lastErr = err
}
}

return nil, lastErr
}

func getSHA(imageName, imageTag string) (string, error) {
Expand Down
Loading