feat: Add override file flag to init command (closes #184) #348
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayowa <[email protected]>
EnriqueL8
reviewed
Nov 14, 2025
| initCmd.PersistentFlags().StringVarP(&initOptions.FireFlyVersion, "release", "r", "latest", fmt.Sprintf("Select the FireFly release version to use. Options are: %v", fftypes.FFEnumValues(types.ReleaseChannelSelection))) | ||
| initCmd.PersistentFlags().StringVarP(&initOptions.ManifestPath, "manifest", "m", "", "Path to a manifest.json file containing the versions of each FireFly microservice to use. Overrides the --release flag.") | ||
| initCmd.Flags().StringVarP(&overrideFile, "file", "f", "", "Custom docker-compose.override.yml file to copy") | ||
| initCmd.PersistentFlags().BoolVar(&promptNames, "prompt-names", false, "Prompt for org and node names instead of using the defaults") |
Contributor
There was a problem hiding this comment.
I'm thinking we could rename this to be more specific this is a docker compose override file instead of just -f or --file . The CLI uses files for all sorts of things including overriding the manifest.json which contains the image.
maybe --override-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a new
-f(or--file) flag to theff initcommand. This new feature allows a user to provide a path to their own customdocker-compose.override.ymlfile, which is then copied into the new stack's directory.This is a helpful feature for DevOps and power users who want to customize their stack (e.g., change ports, add new services) at the moment of creation.
Which issue does this PR fix?
Closes: #184
How was this tested?
I tested this locally by:
go build .touch mytest.yml./firefly-cli.exe init -f mytest.ymlmytest.ymlfile was successfully copied to the new stack's directory (~/.firefly/stacks/teststack) asdocker-compose.override.yml.