Add bg WS connect to common utility - superseding initialConnectAttempts#183
Merged
Add bg WS connect to common utility - superseding initialConnectAttempts#183
Conversation
…ConnectAttempts Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: John Hosie <john.hosie@kaleido.io>
EnriqueL8
reviewed
May 22, 2025
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good - but don't understand the config change, feels like a missing piece there on how that interface is used
include BackgroundConnect in GenerateConfig
Contributor
|
Merged a fix from @hosie and test coverage as well |
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The journey (multiple hops) that lead to hyperledger/firefly#1315 told us that
initialConnectAttemptswas a bit of a flawed coupling strategy between asynchronously starting microservices.We abandoned it, but left the feature in the common library without a clue that it was flawed.
So this PR tries to help other users like me from repeating the mistake :)