[dbsql] [ffapi] Metrics for Go and DB Stats #205
+81
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfuss <[email protected]>
Signed-off-by: hfuss <[email protected]>
Signed-off-by: hfuss <[email protected]>
EnriqueL8
reviewed
Jan 9, 2026
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Thanks @onelapahead - this is great!
A few comments
| opts.dbName = "default" | ||
| } | ||
|
|
||
| metricsRegistry.MustRegisterCollector(collectors.NewDBStatsCollector(db, opts.dbName)) |
Contributor
There was a problem hiding this comment.
Info on stats https://pkg.go.dev/database/sql#DBStats
| as.MetricsRegistry.MustRegisterCollector(collectors.NewProcessCollector(collectors.ProcessCollectorOpts{})) | ||
| as.MetricsRegistry.MustRegisterCollector(collectors.NewGoCollector()) | ||
| } | ||
| as.MetricsRegistry.MustRegisterCollector(collectors.NewBuildInfoCollector()) |
Contributor
There was a problem hiding this comment.
Important comment on this collector:
The labels will only have meaningful values if the binary is built with Go module support and from source code retrieved from the source repository (rather than the local file system).
| alwaysPaginate bool | ||
| handleYAML bool | ||
| monitoringEnabled bool | ||
| goProcessMetricsEnabled bool |
Contributor
There was a problem hiding this comment.
This is whole pkg is already Golang
Suggested change
| goProcessMetricsEnabled bool | |
| processMetricsEnabled bool |
Comment on lines
+51
to
+53
| if opts.dbName == "" { | ||
| opts.dbName = "default" | ||
| } |
Contributor
There was a problem hiding this comment.
Confused on this one, it feels like it should be mandatory to supply a dbName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go metrics can be useful when needing to understand heap usage and how much GC is consuming resources.
DB metrics are self-explanatory.
The ability to enable the default Go/process metrics on the API server, and for clients to manually register/enable DB metrics.