Chain ID included in events#166
Merged
matthew1001 merged 5 commits intohyperledger:mainfrom Apr 29, 2025
Merged
Conversation
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
8fd50db to
502b8e3
Compare
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where it is useful to identify which EVM chain an event has been published from:
An application could bind FF namespace to a given chain, but this can be brittle as per
2above.An application could also assume that for a given contract address the events must be coming from a given chain. But since contract address is a function of sending account and nonce, a contract address can be identical across different chains.
Below is an example
blockchain_event_receivedreceived through FireFly with this PR in place:This PR adds
chainIdto theinfopayload provided byevmconnect. Other connectors could choose to include the same field. It's possible that FF would benefit from it being elevated to a first-class FF event field. Since that is a wider-reaching change I've gone with the smaller change of including it inevmconnect-specific form for now. This doesn't prevent it being added to the mainblockchainEventfields in the future.