Skip to content

Conversation

@ryjones
Copy link
Contributor

@ryjones ryjones commented Jan 30, 2025

Proposed changes

Please include a summary of the changes here and why we need those changes. And also let us know which issue is fixed.

Fixes #1617

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Ry Jones <[email protected]>
@ryjones ryjones requested a review from a team as a code owner January 30, 2025 11:31
@ryjones ryjones requested a review from EnriqueL8 January 30, 2025 11:31
@ryjones ryjones closed this Jan 30, 2025
@ryjones ryjones deleted the fixup branch January 30, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants