Update postgresql16-client to fix docker build#1643
Closed
SupernaviX wants to merge 1 commit intohyperledger:mainfrom
Closed
Update postgresql16-client to fix docker build#1643SupernaviX wants to merge 1 commit intohyperledger:mainfrom
SupernaviX wants to merge 1 commit intohyperledger:mainfrom
Conversation
Signed-off-by: Simon Gellis <simongellis@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 337 337
Lines 29504 29504
=======================================
Hits 29492 29492
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Contributor
|
We just fixed this one as part of #1640 but @SupernaviX would appreciate a PR to pin the version of the base image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bump the
postgresql16-clientversion used in the dockerfile, to one which doesn't conflict with the base image.Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
It might be a good idea to "pin" the manifest's base image:
firefly/manifest.json
Lines 53 to 55 in d87917d
alpine:3.19.7. It's not pinned to a specific patch right now, and this is the second time a patch update has broken the pinned dependency versions in the dockerfile.