[privatemessaging] [operations] Ensure Transports are Networked for Retried Messages#1648
Merged
peterbroadhurst merged 3 commits intohyperledger:mainfrom Feb 28, 2025
Conversation
…etried Messages Signed-off-by: hfuss <[email protected]>
peterbroadhurst
previously approved these changes
Feb 28, 2025
Contributor
peterbroadhurst
left a comment
There was a problem hiding this comment.
Looks great! Must have been a gnarly one to work out.
Linter called out some 2024 headers to update.
Signed-off-by: hfuss <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 337 337
Lines 29593 29607 +14
=======================================
+ Hits 29581 29595 +14
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
peterbroadhurst
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes a bug when retrying sending a private message (dataexchange_send) operation, that the transport wrapper's batch uses the local namespace rather than the network namespace (i.e. the globally unique name for the network) unlike what is done when the message is initially sent.
If the receiver's local namespace does not match the network namespace, it drops the messages as result because it cannot map the namespace + recipient to its local node.
Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
We observed when retrying message operations (related to #1647) that a node might log the following when dropping the received, retried messages: