Bug: newBranch created for E2E test failure with new namespace #1686
Bug: newBranch created for E2E test failure with new namespace #1686aceppaluni wants to merge 28 commits intohyperledger:mainfrom
Conversation
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
actions/upload-artifact and actions/download-artifact have been deprecated and need updated. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Fix CVE-2024-45338 and update Postgres
Signed-off-by: Angelina <aceppaluni@gmail.com>
Signed-off-by: Angelina <aceppaluni@gmail.com>
Signed-off-by: Angelina <aceppaluni@gmail.com> Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Angelina <aceppaluni@gmail.com> Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Angelina <aceppaluni@gmail.com>
Signed-off-by: Angelina <aceppaluni@gmail.com>
| viper.SetDefault(string(CacheTokenPoolTTL), "1h") | ||
| } | ||
|
|
||
| func Reset() { |
There was a problem hiding this comment.
Why did you remove this?
There was a problem hiding this comment.
I had removed setDefualts() as it was not used through out codebase and had wanted to remove anything not in use. If this line serves an additional purpose, happy to add back :)
There was a problem hiding this comment.
This is being used by the tests
Signed-off-by: Angelina <aceppaluni@gmail.com>
| viper.SetDefault(string(CacheTokenPoolTTL), "1h") | ||
| } | ||
|
|
||
| func Reset() { |
There was a problem hiding this comment.
This is being used by the tests
Signed-off-by: Angelina <aceppaluni@gmail.com>
|
@aceppaluni You have conflicts on the |
| UIPath = ffc("ui.path") | ||
| ) | ||
|
|
||
| func setDefaults() { |
There was a problem hiding this comment.
This was the function not being used
Signed-off-by: Angelina <aceppaluni@gmail.com>
|
I resolved the conflicts in mod :) |
|
Going to take this one over and clean it up |
|
Another example of this failing https://github.com/hyperledger/firefly/actions/runs/14754031512/job/41417985010?pr=1674 |
|
See discussion in Discord for this one https://discord.com/channels/905194001349627914/1341066287530512444/1390652656178958487 |
3 participants
Proposed changes
A new PR was created to resolve issues with test failures when adding a new namespace. This PR removes the setDefaults() function as it is not used in codebase.
Fixes #1545
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.