Verify wasm module exports malloc/free #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludvig Liljenberg <[email protected]>
jsturtevant
reviewed
Aug 13, 2025
Comment on lines
+134
to
+136
| // Module must export malloc and free as these | ||
| // are used to marshal param/return values | ||
| if instance.get_func(&mut store, "malloc").is_none() { |
There was a problem hiding this comment.
this is only true if the module uses complex data types like string? I think simple args like int and such can be directly used on the stack
This rust example doesn't export malloc and seems to be working https://github.com/hyperlight-dev/hyperlight-wasm/blob/main/src/rust_wasm_samples/src/lib.rs
|
Closing as we only require malloc/free when using string/vec as parameters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152