Skip to content

Conversation

@simongdavies
Copy link
Contributor

Updates dependabot in order to try and have it update Cargo.lock in test binaries when dependencies in hyperlight_common or hyperlight_guest have changed.

These dependabot PRs currenlty fail because we have a check in the PR workflow to ensure that Cargo.lock files are up to date as a part of any PR which works fine for most scenarios but when dependabot updates depdendencies in either hyperlight_common or hyperlight_guest this may make the Cargo.lock file out of date for the simpleguest and callbackguest test guest binaries.

See #148 , #162 and #161 for examples of this sort of PR

This PR was opened in response to PR feedback on #154, if this doens not work then we will re-openthat PR instead.

@simongdavies simongdavies added the area/dependencies Concerns dependencies or related components label Jan 27, 2025
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@syntactically syntactically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syntactically syntactically merged commit dd31a8a into hyperlight-dev:main Jan 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Concerns dependencies or related components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants