Dont check cargo lock for Rust test guest #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Davies <[email protected]>
simongdavies
added
the
area/infrastructure
ludfjig
approved these changes
Feb 5, 2025
marosset
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out its not so simple to update the test rust guests Cargo.lock file so dependabots PRs dont fail when common crates have dependency updates (as #227 and #154 tried to do) , it can be done but would be error prone and messy so rather than do that this PR removes the enforcement of Cargo.lock being up to date for the test rust guests and reverts the changes from those prior PRs.
Once this merges it should be possible to recreate the PRs #210 #212 and #229 and they should then pass status checks