Skip to content

Static variable __security_cookie should have UPPER_SNAKE_CASE name. `__SECURITY_COOKIE #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Static variable __security_cookie should have UPPER_SNAKE_CASE name. `__SECURITY_COOKIE #272

wants to merge 5 commits into from

Conversation

@myadav27
Copy link
Contributor

@myadav27 myadav27 commented Feb 18, 2025

No description provided.

myadav00 and others added 2 commits February 17, 2025 22:23
@myadav00
change const to uppercase
872df06 
Signed-off-by: myadav <[email protected]>
@simongdavies @myadav00
fix typos (hyperlight-dev#268)
7ab3f32 
Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: myadav <[email protected]>
@danbugs danbugs added the area/infrastructure Concerns infrastructure rather than core functionality label Feb 18, 2025
@simongdavies
Copy link
Contributor

simongdavies commented Feb 27, 2025

@myadav27 please can you signoff the commits to satisfy the DCO check?

@simongdavies
Copy link
Contributor

simongdavies commented Apr 8, 2025

@myadav27 do you have time to update this?

@myadav27
Copy link
Contributor Author

myadav27 commented Apr 9, 2025

I will be setting this aside for now. The linker expects __security_cookie in lowercase, which would require extensive and unnecessary changes across multiple linker files. These changes were also causing existing test cases to break. Given the impact, I’m dropping this effort for the time being.

1 similar comment
@myadav27
Copy link
Contributor Author

myadav27 commented Apr 9, 2025

I will be setting this aside for now. The linker expects __security_cookie in lowercase, which would require extensive and unnecessary changes across multiple linker files. These changes were also causing existing test cases to break. Given the impact, I’m dropping this effort for the time being.

@myadav27 myadav27 closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/infrastructure Concerns infrastructure rather than core functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@myadav27 @simongdavies @danbugs @myadav00