Skip to content

fix access issue in devconatiner #286 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

fix access issue in devconatiner #286 #287

wants to merge 19 commits into from

Conversation

@myadav27
Copy link
Contributor

Devcontainer does not have access to /dev/kvm after resuming a devcontainer in codespaces
#286

@myadav27 myadav27 changed the title fix access issue to devconatiner #286 fix access issue in devconatiner #286 Feb 25, 2025
@myadav27 myadav27 mentioned this pull request Feb 25, 2025
Closed
@dblnz dblnz added kind/bugfix For PRs that fix bugs area/infrastructure Concerns infrastructure rather than core functionality labels Feb 26, 2025
simongdavies
simongdavies requested changes Feb 27, 2025
View reviewed changes
dblnz
dblnz reviewed Feb 27, 2025
View reviewed changes
myadav00 and others added 16 commits March 4, 2025 04:19
@myadav00 @myadav27
fix access issue to devconatiner
165eee2 
Signed-off-by: myadav <[email protected]>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump cc from 1.2.14 to 1.2.15 (hyperlight-dev#281)
2d61f66 
Bumps [cc](https://github.com/rust-lang/cc-rs) from 1.2.14 to 1.2.15.
- [Release notes](https://github.com/rust-lang/cc-rs/releases)
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md)
- [Commits](rust-lang/cc-rs@cc-v1.2.14...cc-v1.2.15)

---
updated-dependencies:
- dependency-name: cc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump serde_json from 1.0.138 to 1.0.139 (hyperlight-dev#279)
d74f8ce 
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.138 to 1.0.139.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.138...v1.0.139)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump anyhow from 1.0.95 to 1.0.96 (hyperlight-dev#277)
c802547 
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.95 to 1.0.96.
- [Release notes](https://github.com/dtolnay/anyhow/releases)
- [Commits](dtolnay/anyhow@1.0.95...1.0.96)

---
updated-dependencies:
- dependency-name: anyhow
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump uuid from 1.13.2 to 1.14.0 (hyperlight-dev#276)
a098630 
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.13.2 to 1.14.0.
- [Release notes](https://github.com/uuid-rs/uuid/releases)
- [Commits](uuid-rs/uuid@v1.13.2...v1.14.0)

---
updated-dependencies:
- dependency-name: uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump serde from 1.0.217 to 1.0.218 (hyperlight-dev#278)
70d63cc 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.217 to 1.0.218.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.217...v1.0.218)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@simongdavies @myadav27
Fix mshv crate version to 0.3.2 (hyperlight-dev#290)
f3806a5 
Signed-off-by: Simon Davies <[email protected]>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump windows-version from 0.1.2 to 0.1.3 (hyperlight-dev#296)
23eba20 
Bumps [windows-version](https://github.com/microsoft/windows-rs) from 0.1.2 to 0.1.3.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits)

---
updated-dependencies:
- dependency-name: windows-version
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump libc from 0.2.169 to 0.2.170 (hyperlight-dev#295)
3ab22a6 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.169 to 0.2.170.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.170/CHANGELOG.md)
- [Commits](rust-lang/libc@0.2.169...0.2.170)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump uuid from 1.14.0 to 1.15.1 (hyperlight-dev#294)
20e7495 
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.14.0 to 1.15.1.
- [Release notes](https://github.com/uuid-rs/uuid/releases)
- [Commits](uuid-rs/uuid@v1.14.0...v1.15.1)

---
updated-dependencies:
- dependency-name: uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump crate-ci/typos from 1.29.7 to 1.29.10 (hyperlight-dev#289)
d159c93 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.29.7 to 1.29.10.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.29.7...v1.29.10)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dependabot @myadav27
Bump log from 0.4.25 to 0.4.26 (hyperlight-dev#292)
7215c13 
Bumps [log](https://github.com/rust-lang/log) from 0.4.25 to 0.4.26.
- [Release notes](https://github.com/rust-lang/log/releases)
- [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md)
- [Commits](rust-lang/log@0.4.25...0.4.26)

---
updated-dependencies:
- dependency-name: log
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@ludfjig @myadav27
Generic guest/host result API (hyperlight-dev#259)
c06b052 
* Make `get_flatbuffer_result` generic

Signed-off-by: Ludvig Liljenberg <[email protected]>

* Make `get_host_value_return_as` generic

Signed-off-by: Ludvig Liljenberg <[email protected]>

* fix broken rebase

Signed-off-by: Ludvig Liljenberg <[email protected]>

---------

Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@ludfjig @myadav27
Run clippy on guests in CI (hyperlight-dev#237)
3005ed5 
* Clippy guests

Signed-off-by: Ludvig Liljenberg <[email protected]>

* Add matrix target to recipe

Signed-off-by: Ludvig Liljenberg <[email protected]>

* fix broken rebase

Signed-off-by: Ludvig Liljenberg <[email protected]>

---------

Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@dblnz @myadav27
devcontainer install gdb and vscode ext for debugging (hyperlight-dev…
5d4f9bd 
…#291)

Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@myadav27
move setup command to bash file
fba3ec3 
Signed-off-by: Ubuntu <newton-x1@svc-ado-007.ouans5uoojaeda1bo2vkwkz51c.bx.internal.cloudapp.net>
Signed-off-by: Manoj Kumar Yadav <[email protected]>
@myadav27 myadav27 force-pushed the devconatiner_kvm_permission_fix branch from 149f484 to fba3ec3 Compare March 4, 2025 04:19
@myadav27 myadav27 requested a review from simongdavies March 4, 2025 04:20
dblnz
dblnz reviewed Mar 4, 2025
View reviewed changes
@myadav27 myadav27 force-pushed the devconatiner_kvm_permission_fix branch from 8084555 to e11cc6a Compare March 4, 2025 15:21
@dblnz
Copy link
Contributor

dblnz commented Mar 5, 2025

To pass the DCO check, please sign your commits.

@myadav27
Copy link
Contributor Author

myadav27 commented Mar 5, 2025 •
edited
Loading

To pass the DCO check, please sign your commits.

@dblnz could you please refer #326 with correct code and sign off. I will abandon sign off, since I was committing with different account and was causing the issue. I will close his pr.

@myadav27 myadav27 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblnz dblnz dblnz left review comments

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees

No one assigned

Labels

area/infrastructure Concerns infrastructure rather than core functionality kind/bugfix For PRs that fix bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@myadav27 @dblnz @simongdavies @myadav00 @ludfjig