Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ValidatePullRequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Spell Check Repo
uses: crate-ci/typos@v1.29.10
uses: crate-ci/typos@v1.30.0

# Gate PR merges on this specific "join-job" which requires all other
# jobs to run first. We need this job since we cannot gate on particular jobs
Expand All @@ -86,4 +86,3 @@ jobs:
- name: Previous jobs failed
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
run: exit 1

Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ fn ensure_surrogate_process_exe() -> Result<()> {

if embedded_file_sha != file_on_disk_sha {
println!(
"sha of embedded surrorate '{}' does not match sha of file on disk '{}' - deleting surrogate binary at {}",
"sha of embedded surrogate '{}' does not match sha of file on disk '{}' - deleting surrogate binary at {}",
embedded_file_sha,
file_on_disk_sha,
&surrogate_process_path.display()
Expand Down
2 changes: 1 addition & 1 deletion src/hyperlight_host/src/mem/mgr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ impl SandboxMemoryManager<HostSharedMemory> {
// the guest manipulating this memory location because the only
// addresses that are valid are in its own address space.
//
// When executing in-process, maniulating this pointer could cause the
// When executing in-process, manipulating this pointer could cause the
// host to execute arbitrary functions.
let guest_ptr = GuestPtr::try_from(RawPtr::from(guest_dispatch_function_ptr))?;
guest_ptr.absolute()
Expand Down
4 changes: 2 additions & 2 deletions src/hyperlight_host/src/mem/shared_mem.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ unsafe impl Send for GuestSharedMemory {}
/// sadly, mostly un-adopted for C++23, although that does not concern
/// us), the paper did not actually redefine volatile accesses or data
/// races to prevent volatile accesses from racing with other accesses
/// and causing undefined behaviour. P1382R1 [5] would have amendend
/// and causing undefined behaviour. P1382R1 [5] would have amended
/// the wording of the data race definition to specifically exclude
/// volatile, but, unfortunately, despite receiving a
/// generally-positive reception at its first WG21 meeting more than
Expand Down Expand Up @@ -257,7 +257,7 @@ unsafe impl Send for GuestSharedMemory {}
/// In short, none of the Rust-level operations available to us do the
/// right thing, at the Rust spec level or the LLVM spec level. Our
/// major remaining options are therefore:
/// - Choose one of the options that is avaiblale to us, and accept
/// - Choose one of the options that is available to us, and accept
/// that we are doing something unsound according to the spec, but
/// hope that no reasonable compiler could possibly notice.
/// - Use inline assembly per architecture, for which we would only
Expand Down
2 changes: 1 addition & 1 deletion src/hyperlight_host/src/sandbox/initialized_multi_use.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ impl MultiUseSandbox {
/// // original `sbox` variable.
/// let mut ctx = sbox.new_call_context();
///
/// // Do a guest call with the context. Assues that the loaded binary
/// // Do a guest call with the context. Assumes that the loaded binary
/// // ("some_guest_binary") has a function therein called "SomeGuestFunc"
/// // that takes a single integer argument and returns an integer.
/// match ctx.call(
Expand Down
4 changes: 4 additions & 0 deletions typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ extend-ignore-identifiers-re = ["Fo"]

[files]
extend-exclude = ["**/*.patch", "src/hyperlight_guest/third_party/**/*", "NOTICE.txt"]

[default.extend-words]
# typ is used for field name as type is a reserved keyword
typ="typ"
Loading