Skip to content

[bugfix] Fix case where memory was reset, but host still tried to read result value from memory #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[bugfix] Fix case where memory was reset, but host still tried to read result value from memory #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hyperlight_host/src/func/guest_dispatch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,13 @@ pub(crate) fn call_function_on_guest<WrapperGetterT: WrapperGetter>(
timedout = true;
match hv_handler.terminate_hypervisor_handler_execution_and_reinitialise(
wrapper_getter.get_mgr_wrapper_mut().unwrap_mgr_mut(),
)? {
HyperlightError::HypervisorHandlerExecutionCancelAttemptOnFinishedExecution() =>
{}
) {
Ok(
HyperlightError::HypervisorHandlerExecutionCancelAttemptOnFinishedExecution(),
) => {}
// ^^^ do nothing, we just want to actually get the Flatbuffer return value
// from shared memory in this case
e => return Err(e),
Ok(e) | Err(e) => return Err(e),
}
}
e => return Err(e),
Expand Down
Loading