Removed host error region #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbugs
added
the
kind/refactor
ludfjig
previously approved these changes
May 2, 2025
…d host error region This region was unused. Ever since we ported our code from C# to Rust, if there's an error calling a host function, the host will just error out instead of returning to the guest, which is probably more sensible. Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
remove-host-exception-region
branch
from
83e65ad to
a327f50
Compare
ludfjig
previously approved these changes
May 2, 2025
danbugs
force-pushed
the
remove-host-exception-region
branch
from
a327f50 to
6091ff7
Compare
…toml - serde* - lazy_static I also removed HyperlightHostError, which is now unused. Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
remove-host-exception-region
branch
from
6091ff7 to
d1a90c1
Compare
ludfjig
approved these changes
May 5, 2025
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
May 6, 2025
Removed cfg options that became unused after PRs hyperlight-dev#451 , hyperlight-dev#453 , and hyperlight-dev#457 merged. Signed-off-by: danbugs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This region was unused. Ever since we ported our code from C# to Rust, if there's an error calling a host function, the host will just error out instead of returning to the guest, which is probably more sensible.