Unify HostFunctionXX traits into a single HostFunction #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
added
area/API
jprendes
force-pushed
the
host_function
branch
2 times, most recently
from
db41478 to
e942802
Compare
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the previously separate HostFunctionXX traits into a single HostFunction trait for host function registration. The key changes include updating imports, function parameters, and macro implementations, resulting in a more streamlined API across tests, examples, and the core host function implementation.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hyperlight_host/tests/sandbox_host_tests.rs | Updated import from HostFunction1 to HostFunction. |
| src/hyperlight_host/tests/common/mod.rs | Replaced HostFunction1 with HostFunction in function parameters. |
| src/hyperlight_host/src/sandbox/uninitialized.rs | Updated host function parameter types from HostFunction1 to HostFunction. |
| src/hyperlight_host/src/func/mod.rs | Removed re-exports for legacy HostFunctionXX traits and exposed HostFunction. |
| src/hyperlight_host/src/func/host_functions.rs | Revised macro implementation to support the unified HostFunction trait. |
| src/hyperlight_host/src/func/guest_dispatch.rs | Updated import from HostFunction0 to HostFunction. |
| Examples and benches | Updated usage of HostFunction trait consistently in place of earlier HostFunctionX versions. |
danbugs
reviewed
May 7, 2025
dblnz
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the HostFunctionXX traits, and replaces them with a single HostFunction trait.