Fix docs only CI job processing #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
previously approved these changes
Nov 8, 2024
devigned
force-pushed
the
fix-filter
branch
3 times, most recently
from
90bcdb7 to
78fd3e6
Compare
|
FYI, this makes docs updates take ~15s to pass CI. |
jprendes
reviewed
Nov 8, 2024
devigned
force-pushed
the
fix-filter
branch
2 times, most recently
from
d3b57d9 to
8749a83
Compare
jprendes
requested changes
Nov 8, 2024
devigned
force-pushed
the
fix-filter
branch
2 times, most recently
from
9eb0f04 to
db3f871
Compare
Signed-off-by: David Justice <[email protected]>
Thank you! Really appreciate your reviews. |
danbugs
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44, I attempted to ignore docs only CI job processing, but branch protection required jobs were still required to run. The only way to satisfy the branch protection required jobs is to have them run, but return with success. This PR does that by using conditional execution for the job rather than filtering on the PR content in the
pull_requestevent handler.