Remove support for building PE files from hyperlight-guest-bin build.rs #572
Conversation
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
simongdavies
added
the
kind/enhancement
There was a problem hiding this comment.
Looks reasonable, maybe @syntactically could have a look as she wrote the code
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
from
d16d57c to
1193045
Compare
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
from
1193045 to
04757e5
Compare
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
2 times, most recently
from
de7e451 to
e9b327d
Compare
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
from
e9b327d to
e9f405f
Compare
|
@syntactically @jprendes please take another look when you have a moment |
Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
from
e9f405f to
c37c889
Compare
There was a problem hiding this comment.
LGTM.
Your comment about not seeing failures with clang.exe made me realise that I'm not sure if we actually have any tests in core hyperlight that make sure this toolchain works to build something; we used to use it to build WAMR when we were experimenting with that, but I don't think we have anything using it right now. It would be nice to add a test guest that actually builds libz or openssl or something with it, though. I don't know if it makes sense to that as part of this PR, but maybe add an issue for it if not?
4 participants
This pull request simplifies the build process for the
hyperlight_guest_binby removing support for Windows-specific tools and configurations since we no longer support PE guests.