Fixes a race condition in killing Sandboxes #957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as successfully exited causing the subsequent run to fail Signed-off-by: Simon Davies <[email protected]>
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
jsturtevant
reviewed
Oct 15, 2025
| // So we check to see if we really cancelled the vCPU or if it was just a normal exit and set the `cancelled` flag accordingly | ||
| // The order of setting the flags is important here, we need to set `cancelled` before clearing `running` as the `InterruptHandle::send_signal()` checks `running` to know when to stop sending signals | ||
| // and then checks to see if the vCPU was cancelled or not and clears the `cancel_requested` flag if it was. | ||
| // This prevents the case where we receive a cancel request after the vCPU has as below we only return cancelled if the vCPU was actually cancelled |
There was a problem hiding this comment.
This sentence is a bit awkward
|
Closed in favour of #959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where a sandbox kill arrives after a sandbox has successfully exited causing the subsequent run to fail