Skip to content

fix: default turn the option on #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WalkerLiuFei wants to merge 2 commits into from
Closed

fix: default turn the option on #171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d379d
fix: default turn the option on
Jul 3, 2025
8c185bc
fix: fix format.
Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hyperliquid/utils/signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def address_to_bytes(address):


def action_hash(action, vault_address, nonce, expires_after):
data = msgpack.packb(action)
data = msgpack.packb(action,use_bin_type=True)
Copy link
Contributor

@traderben traderben Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already the default value: https://msgpack-python.readthedocs.io/en/latest/api.html

Copy link
Author

@WalkerLiuFei WalkerLiuFei Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In earlier versions, this flag defaults to False. Python’s dependency management can be chaotic for those are not familier with Python. When they using the wrong msgpack version would quickly becomes a nightmare. I ran into this exact issue and ended up spending a whole night tracking down .

Copy link
Contributor

@traderben traderben Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyproject.toml specifies that the minimum required version of msgpack is 1.0.5 so that shouldn't be possible. I don't think it's worth programming this defensively

data += nonce.to_bytes(8, "big")
if vault_address is None:
data += b"\x00"
Expand Down
Loading