Skip to content

Conversation

@kfastov
Copy link
Contributor

@kfastov kfastov commented Sep 4, 2025

Why:

The Rust version is misaligned between CI and rust-toolchain.toml:

  • CI installs stable rustfmt/clippy;
  • rust-toolchain.toml requires nightly;

This causes cargo fmt to fail during CI.

Proposition:

  • We can safely change pinned toolchain version to "stable" because the repo doesn't use any nightly features yet

Changes:

  • Set rust-toolchain.toml to channel = "stable".
  • Fix clippy warnings to ensure CI passes

Result: build/fmt/clippy/tests run on stable; CI passes.

@kfastov kfastov marked this pull request as ready for review September 4, 2025 14:13
@kfastov
Copy link
Contributor Author

kfastov commented Sep 5, 2025

@lmlmt What do you think?

@lmlmt lmlmt self-requested a review October 20, 2025 23:27
@lmlmt
Copy link
Contributor

lmlmt commented Oct 20, 2025

@lmlmt What do you think?

Sounds good, thanks!

@lmlmt lmlmt merged commit 701ce47 into hyperliquid-dex:master Oct 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants