fix: use book diff px for new orders and handle empty books in valida… #9
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion
Two fixes for snapshot validation failures:
1. Use price from book diff instead of order status for new orders
- The BookDiff.px field contains the actual price the order entered
the book at, which can differ from OrderStatus.limit_px (e.g., for
triggered orders)
- Added modify_px method to InnerOrder trait and InnerL4Order impl
- Added px() getter to NodeDataOrderDiff
2. Treat empty orderbooks as equivalent to non-existent in validation
- Previously, if expected snapshot had an empty book for a coin that
didn't exist in our state, validation would incorrectly fail with
"Extra orderbooks detected"
- Now filters out empty books before checking for extras
Tested on a non-validator node where the unfixed version crashes with
price mismatch errors while the fixed version runs stably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for snapshot validation failures:
Use price from book diff instead of order status for new orders
Treat empty orderbooks as equivalent to non-existent in validation