Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@octref
Copy link
Contributor

@octref octref commented Nov 19, 2024

Description

  • Use user provided name for package.json and go.mod
  • Remove package-lock.json from the template, as it'll be recreated during npm install for new projects

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

@octref octref requested a review from a team November 19, 2024 21:35
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's just use go mod edit -module <name> in the cli. We're already doing the equivalent for NPM. Thanks.

@octref octref enabled auto-merge (squash) November 19, 2024 23:32
@octref octref merged commit 7b9dacc into main Nov 20, 2024
34 checks passed
@octref octref deleted the pine/modus-new-names branch November 20, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants