Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@octref
Copy link
Contributor

@octref octref commented Nov 21, 2024

Description

  • set scarfSettings.allowTopLevel to track modus-cli install through curl
  • normalize all variables collected to lower case

See https://docs.scarf.sh/package-analytics/#configuration
Basically, we install the CLI into a global folder instead of doing npm i -g, so this install will not trigger scarf.
Caveat: When someone is setting up CLI dev locally for first time, npm i will trigger one install count. This install will be cached and subsequent npm i won't trigger it.

This is just to follow up with the previous PR, so I won't write a new Changelog entry.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

@octref octref requested a review from a team November 21, 2024 05:42
@octref octref enabled auto-merge (squash) November 21, 2024 17:00
@octref octref merged commit 05abc06 into main Nov 21, 2024
6 checks passed
@octref octref deleted the pine/scarf-followup branch November 21, 2024 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants