Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

fix: use git commit with double quotes for Windows #612

Merged
octref merged 2 commits into from
Nov 25, 2024
Merged

fix: use git commit with double quotes for Windows #612

octref merged 2 commits into from
Nov 25, 2024

Conversation

@octref
Copy link
Contributor

@octref octref commented Nov 25, 2024

Description

git commit -m 'commit' might fail on Windows.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

@octref octref requested a review from a team November 25, 2024 18:10
@octref octref merged commit a60679f into main Nov 25, 2024
6 checks passed
@octref octref deleted the pine/fix-windows-git-commit branch November 25, 2024 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@octref @mattjohnsonpint