Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Jan 10, 2025

Description

#696 fixed Go builds when the user had a space in their user home directory, but it broke AssemblyScript builds on Windows. This fixes the problem.

See https://discord.com/channels/1267579648657850441/1301895154264965141/1327049139963301900 for discussion.

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.

@mattjohnsonpint mattjohnsonpint requested a review from a team January 10, 2025 00:08
@mattjohnsonpint mattjohnsonpint merged commit ed39ee3 into main Jan 10, 2025
6 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2920-modus-cli-errors branch January 10, 2025 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants