Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Mar 12, 2025

Description

Cleanup package dependencies in all AssemblyScript projects and the Modus CLI.

  • Remove dev dependencies no longer needed.
    • @types/eslint__js and @typescript-eslint/parser are no longer required
    • visitor-as is no longer required
    • the AssemblyScript override is no longer required
  • Update remaining NPM packages to their latest versions
  • Update the build-plugin.js script to align to the latest true requirements
  • Fix a compiler warning in one of the examples

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot March 12, 2025 21:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up unused dependencies and upgrades remaining ones across multiple projects while updating related build scripts and resolving a compiler warning in an AssemblyScript example.

  • Removed no-longer-needed dev dependencies and unnecessary AssemblyScript overrides for projects not using as-test.
  • Updated the CHANGELOG entries for CLI and AssemblyScript SDK releases.
  • Adjusted the ExampleClaims class in the AssemblyScript auth example to use explicit default initializations instead of non-null assertions.

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.

File Description
CHANGELOG.md Added new release notes for CLI and AssemblyScript SDK with updated entries.
sdk/assemblyscript/examples/auth/assembly/index.ts Replaced non-null assertions with explicit default initializations in the ExampleClaims class to resolve a compiler warning and ensure consistent default values.

@mattjohnsonpint mattjohnsonpint marked this pull request as draft March 12, 2025 21:27
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review March 12, 2025 21:37
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) March 12, 2025 22:04
@mattjohnsonpint mattjohnsonpint marked this pull request as draft March 13, 2025 04:17
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review March 13, 2025 04:18
@mattjohnsonpint mattjohnsonpint merged commit 60f0c6d into main Mar 13, 2025
66 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/cleanup branch March 13, 2025 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants