This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: validate manifest with new dgraph connection string format #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnymontana
approved these changes
Apr 10, 2025
mattjohnsonpint
deleted the
mjp/hyp-3184-manifest-validation-error-when-using-new-dgraph-connection
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #803 we added support for the new Dgraph connection string format in the Modus Runtime, and updated the manifest library and Go SDK at that time - but we didn't release an update for the Go SDK (oops).
So mainly this PR is to update the changelog and serve as a commit for the release tag, but the work was already done in #803.
Also updating the examples of both SDKs to use the new format.