This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: correct agent base event stubs #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames outdated event stubs in AgentBase, correcting method names and adding a missing termination handler.
- Rename
OnStop→OnSuspend - Rename
OnReload→OnRestore - Add new
OnTerminatestub - Update
CHANGELOG.mdwith the fix entry
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/go/pkg/agents/agents.go | Renamed two methods and added a missing termination stub |
| CHANGELOG.md | Added changelog entry for Go SDK 0.18.0-alpha.2 |
Comments suppressed due to low confidence (1)
sdk/go/pkg/agents/agents.go:232
- No tests appear to cover the new
OnTerminatestub. Add unit tests or integration tests to verify that the termination event is correctly propagated.
func (a *AgentBase) OnTerminate() error {
kevinmingtarja
approved these changes
May 19, 2025
mattjohnsonpint
deleted the
mjp/hyp-3384-agentbase-is-missing-some-default-event-stubs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #843