This repository was archived by the owner on Sep 11, 2025. It is now read-only.
chore: update json-as and remove hack #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the json-as dependency to version 1.1.2 and removes a previously needed hack. The changes ensure consistency across multiple AssemblyScript example projects and update the changelog to reflect these modifications.
- Upgraded json-as from ^1.0.8 to ^1.1.2 in various examples.
- Removed outdated hack as it is no longer required.
- Updated CHANGELOG to document the change.
Reviewed Changes
Copilot reviewed 28 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/assemblyscript/examples/http/package.json | Updated json-as version |
| sdk/assemblyscript/examples/graphql/package.json | Updated json-as version |
| sdk/assemblyscript/examples/embedding/package.json | Updated json-as version |
| sdk/assemblyscript/examples/dgraph/package.json | Updated json-as version |
| sdk/assemblyscript/examples/collections/package.json | Updated json-as version |
| sdk/assemblyscript/examples/classification/package.json | Updated json-as version |
| sdk/assemblyscript/examples/auth/package.json | Updated json-as version |
| sdk/assemblyscript/examples/anthropic-functions/package.json | Updated json-as version |
| sdk/assemblyscript/examples/agents/package.json | Updated json-as version |
| CHANGELOG.md | Added changelog entry for the update |
Files not reviewed (10)
- sdk/assemblyscript/examples/agents/package-lock.json: Language not supported
- sdk/assemblyscript/examples/anthropic-functions/package-lock.json: Language not supported
- sdk/assemblyscript/examples/auth/package-lock.json: Language not supported
- sdk/assemblyscript/examples/classification/package-lock.json: Language not supported
- sdk/assemblyscript/examples/collections/package-lock.json: Language not supported
- sdk/assemblyscript/examples/dgraph/package-lock.json: Language not supported
- sdk/assemblyscript/examples/embedding/package-lock.json: Language not supported
- sdk/assemblyscript/examples/graphql/package-lock.json: Language not supported
- sdk/assemblyscript/examples/http/package-lock.json: Language not supported
- sdk/assemblyscript/examples/mysql/package-lock.json: Language not supported
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
ryanfoxtyler
approved these changes
May 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all AssemblyScript projects to latest
json-asv1.1.5, and remove previous hack that is no longer needed.