This repository was archived by the owner on Sep 11, 2025. It is now read-only.
feat: remove embedded PostgresDB #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes the embedded PostgreSQL database feature now that ModusGraph v0.1.0 works reliably on Windows, and cleans up related dependencies and code.
- Deleted all embedded-Postgres setup/teardown code.
- Removed embedded-Postgres dependencies and replace directives from go.mod.
- Simplified DB startup logic and updated changelog and spelling config.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/go.mod | Removed embedded-Postgres and migrate deps. |
| runtime/db/embeddedpg.go | Deleted file containing embedded-Postgres logic. |
| runtime/db/db.go | Removed calls to prepare/shutdown embedded DB; simplified useModusDB. |
| CHANGELOG.md | Added “remove embedded PostgresDB” under UNRELEASED. |
| .trunk/configs/cspell.json | Removed embedded-Postgres terms from spelling list. |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
kevinmingtarja
approved these changes
May 30, 2025
kevinmingtarja
added a commit
that referenced
this pull request
May 30, 2025
This reverts commit 9de1a7e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further testing with ModusGraph
v0.1.0, it is working fine on Windows, so we don't need the embedded PostgresDB added in #851 afterall.