This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: remove ack event from SSE stream #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ack event from the SSE stream to align with the GraphQL-SSE specification and prevent client-side errors.
- Removes the ack event output and its associated comment in the SSE stream handler.
- Updates the CHANGELOG.md to reflect this removal.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| runtime/graphql/graphql.go | Removed ack event printing for proper SSE behavior. |
| CHANGELOG.md | Added changelog entry to document the removal change. |
kevinmingtarja
approved these changes
Jun 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
ackevent from the SSE stream, so the stream conforms to the GraphQL-SSE spec.This should prevent errors where the client doesn't know how to handle undefined events, such as seen here:
