This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: resolve deadlocks related to open inbound http connections #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an SSE connection was open and streaming subscriptions, we'd get a hung deadlock until the connection was closed, after reloading the wasm module (such as if user code changes were deployed, or in a
modus devloop).The main deadlock was related to the map in our "dynamic mux". I replaced it with a lock-free xsync map to resolve that issue.
I also found that an open subscription was preventing clean shutdown, which was resolve by keeping track of open subscriptions and cancelling them during shutdown.
Also includes a few other misc bugs that were noticed along the way.