This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: improve cluster resiliency #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve cluster resiliency by updating dependencies, refining cluster configuration options, and enhancing the shutdown and logging behavior of the actor system.
- Dependency updates in go.mod for improved compatibility and fixes.
- Consolidated configuration retrieval for environment variables and refined cluster and shutdown handling in actor-related modules.
- Adjusted logging behavior and minor updates in configurations and documentation.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runtime/go.mod | Updated dependency versions to address warnings and errors. |
| runtime/actors/misc.go | Added helper for reading environment variables with integer conversion. |
| runtime/actors/cluster.go | Replaced direct port parsing with getIntFromEnv and enhanced timeout configuration. |
| runtime/actors/actorsystem.go | Updated shutdown procedures and in-cluster actor restoration with improved error handling. |
| runtime/actors/actorlogger.go | Enhanced logging with pause/resume and conditional message filtering. |
| CHANGELOG.md | Documented the fixes and improvements for cluster resiliency. |
| .vscode/launch.json | Commented out debug flag to disable debug actor logging in VS Code launch configuration. |
| .trunk/configs/cspell.json | Added new allowed term for improved code spell checking. |
kevinmingtarja
approved these changes
Jun 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several fixes and improvements for cluster mode to improve resiliency and address warnings and errors seen in our logs.