This repository was archived by the owner on Sep 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
fix: adjust cluster sync settings and delays #902
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattjohnsonpint
commented
Jun 23, 2025
- Adjust cluster sync default settings based on results of further testing
- Add delays where needed to allow time for peer sync
- Some refactoring and comments added
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines cluster synchronization behavior by centralizing configuration into helper functions, introducing delays to ensure state consistency, and cleaning up log noise.
- Refactor cluster default settings into dedicated functions (hosts, timeouts, intervals, partition count).
- Add
waitForClusterSynccalls to coordinate actor spawning across nodes. - Filter expected shutdown messages in actor logger and bump dependencies.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/go.mod | Bump goakt dependency to v3.6.6 and update version checksum |
| runtime/actors/cluster.go | Extract cluster settings into helper functions; adjust defaults |
| runtime/actors/agents.go | Add waitForClusterSync after spawning a new agent actor |
| runtime/actors/actorsystem.go | Invoke waitForClusterSync on startup; refactor agent restoration |
| runtime/actors/actorlogger.go | Suppress expected semaphore cancellation logs |
| CHANGELOG.md | Document new alpha version with sync improvements |
Comments suppressed due to low confidence (1)
runtime/actors/cluster.go:154
- [nitpick] The new helper functions (
remotingHost,partitionCount,readTimeout, etc.) are not covered by tests. Adding unit tests for these will ensure environment-variable overrides work as expected.
func remotingHost() string {
ryanfoxtyler
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.