Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Attempt to fix #917

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot June 27, 2025 00:10
@linear
Copy link

linear bot commented Jun 27, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A fix to prevent publishing events when the topic actor is not running and update the changelog accordingly

  • Guard added in PublishAgentEvent to skip publishing if the topic actor has stopped
  • Warning logged instead of error when skipping event publication during shutdown
  • Changelog updated under an UNRELEASED section to document the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
runtime/actors/agents.go Added a check for topicActor.IsRunning() with a warning and early return
CHANGELOG.md Documented the new fix under an UNRELEASED section
Comments suppressed due to low confidence (2)

runtime/actors/agents.go:270

  • Add a unit test covering the case when the topic actor is not running to verify that events are correctly skipped.
	if !topicActor.IsRunning() {

CHANGELOG.md:7

  • Use a level-2 markdown header (e.g., "## UNRELEASED") to match the formatting of other release entries in the changelog.
UNRELEASED

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) June 27, 2025 00:11
@mattjohnsonpint mattjohnsonpint merged commit d931945 into main Jun 27, 2025
33 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/mod-6-remote-send-failed-actor-is-not-alive branch June 27, 2025 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

remote send failed, actor is not alive

3 participants