Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Further improvements to Sentry usage.

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot July 9, 2025 18:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves Sentry usage by consolidating and enhancing error reporting and tracing capabilities across the runtime. The changes extract Sentry utilities into a dedicated package to provide better error context, structured breadcrumbs, and cleaner stack traces while removing automatic error capture from the logger.

  • Created a new sentryutils package with enhanced error reporting, breadcrumb support, and improved stack trace filtering
  • Replaced direct Sentry usage and automatic logger error capture with explicit sentryutils.CaptureError calls throughout the codebase
  • Updated build configuration to preserve debug symbols for better error reporting

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
runtime/sentryutils/sentry.go New comprehensive Sentry utilities package with enhanced error reporting and tracing
runtime/utils/sentry.go Removed old Sentry utilities (moved to dedicated package)
runtime/logger/logger.go Removed automatic Sentry error capture from logger functions
runtime/wasmhost/* Updated to use new sentryutils package and explicit error reporting
runtime/storage/* Updated to use new sentryutils package and explicit error reporting
runtime/secrets/* Updated to use new sentryutils package and explicit error reporting
runtime/plugins/* Updated to use new sentryutils package and explicit error reporting
runtime/models/* Updated to use new sentryutils package and explicit error reporting
runtime/main.go Updated to use new sentryutils initialization
runtime/Makefile Removed debug symbol stripping for better error reporting
Comments suppressed due to low confidence (3)

runtime/sentryutils/sentry.go:27

  • The constant name 'max_breadcrumbs' should use camelCase or PascalCase according to Go naming conventions. Consider renaming to 'maxBreadcrumbs'.
const max_breadcrumbs = 100

runtime/sentryutils/sentry.go:264

  • Using the incorrectly named constant 'max_breadcrumbs'. Should use 'maxBreadcrumbs' after fixing the naming issue.
		scope.AddBreadcrumb(breadcrumb, max_breadcrumbs)

runtime/sentryutils/sentry.go:276

  • Using the incorrectly named constant 'max_breadcrumbs'. Should use 'maxBreadcrumbs' after fixing the naming issue.
	scope.AddBreadcrumb(breadcrumb, max_breadcrumbs)

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) July 9, 2025 18:50
@ryanfoxtyler ryanfoxtyler disabled auto-merge July 9, 2025 18:51
@mattjohnsonpint mattjohnsonpint merged commit ec140a3 into main Jul 9, 2025
33 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/sentry branch July 9, 2025 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants