Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Update GoAkt to latest v3.7.0 and update code to match breaking changes

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot July 9, 2025 18:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GoAkt dependency to v3.7.0 and adapts the coordinated shutdown implementation to the new ShutdownHook interface.

  • Bump several indirect dependencies in go.mod (GoAkt, gnostic-models, cpuid, OpenTelemetry, Kube OpenAPI, YAML libraries)
  • Replace WithCoordinatedShutdown(beforeShutdown) callback with a new shutdownHook type implementing Execute and Recovery
  • Remove the old beforeShutdown function and inline its logic into shutdownHook

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
runtime/go.mod Updated versions for GoAkt and other indirect dependencies
runtime/actors/actorsystem.go Refactored coordinated shutdown: removed beforeShutdown, added shutdownHook
Comments suppressed due to low confidence (3)

runtime/actors/actorsystem.go:204

  • [nitpick] The type name shutdownHook is quite generic; consider renaming it to something more descriptive (e.g., actorShutdownHook) to clarify its specialized role.
type shutdownHook struct {

runtime/actors/actorsystem.go:207

  • Consider adding unit tests for shutdownHook.Execute and its Recovery logic to ensure the retry behavior and actor suspend/shutdown flows work as expected.
func (sh *shutdownHook) Execute(ctx context.Context, actorSystem goakt.ActorSystem) error {

runtime/go.mod:272

  • Both go.yaml.in/yaml and gopkg.in/yaml.v3 are now indirect dependencies; evaluate if you need both to avoid duplication or potential version conflicts.
	go.yaml.in/yaml/v2 v2.4.2 // indirect

@mattjohnsonpint mattjohnsonpint merged commit 6de0bcc into main Jul 9, 2025
33 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/goakt-update branch July 9, 2025 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants