Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Fixes #944

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot July 12, 2025 05:36
@linear
Copy link

linear bot commented Jul 12, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates the application’s zerolog-based logger with controller-runtime for Kubernetes secrets watching by passing context into the client factory and setting the global logger. It also adds the zerologr dependency and updates the changelog.

  • Import and use zerologr to set controller-runtime’s logger from context
  • Update newK8sClientForSecret signature and call sites to accept context.Context
  • Add github.com/go-logr/zerologr to dependencies and document the change in CHANGELOG.md

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
runtime/secrets/kubernetes.go Added zerologr import, passed ctx to client factory, set controller logger, updated function signature and call
runtime/go.mod Added github.com/go-logr/zerologr dependency
CHANGELOG.md Added entry for the “connect kubernetes logger” fix
Comments suppressed due to low confidence (2)

runtime/secrets/kubernetes.go:159

  • Update the function doc comment to mention the new ctx context.Context parameter, so it stays accurate after the signature change.
// newK8sClientForSecret creates a new Kubernetes client that watches

CHANGELOG.md:11

  • Verify that the issue or PR reference number matches the intended ticket (the description says it fixes #944 but this entry uses #945).
- fix: connect kubernetes logger [#945](https://github.com/hypermodeinc/modus/pull/945)

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) July 12, 2025 05:38
@mattjohnsonpint mattjohnsonpint disabled auto-merge July 12, 2025 05:56
@mattjohnsonpint mattjohnsonpint merged commit 408dad1 into main Jul 12, 2025
32 of 33 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/mod-11-k8s-secrets-provider-logger-warning branch July 12, 2025 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

k8s secrets provider logger warning

2 participants