Fix CodeQL security warnings in Flask app#29
Merged
hyperpolymath merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
- Fix Flask debug mode: Use environment variable FLASK_DEBUG instead of hardcoded debug=True to prevent running in debug mode in production - Fix unsafe HTML construction in JavaScript client library: - Replace innerHTML with safe DOM API methods (createElement, textContent) - Add sanitizeUrl helper to prevent javascript:/data: protocol XSS attacks - Build SVG elements using createElementNS for safer rendering - Add explicit permissions to GitHub Actions workflows: - test.yml: contents: read - security.yml: contents: read (workflow-level), issues: write (security-summary job) - build.yml: contents: read - rsr-compliance.yml: contents: read - ci.yml: contents: read - docs.yml: contents: write, pages: write, id-token: write (for gh-deploy) These changes follow the principle of least privilege and address all CodeQL security warnings for Flask debug mode, unsafe HTML construction, and missing workflow permissions.
hyperpolymath
deleted the
claude/fix-codeql-flask-security-018YbVK86qBYP9xXzWDDeLug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Flask debug mode: Use environment variable FLASK_DEBUG instead of hardcoded debug=True to prevent running in debug mode in production
Fix unsafe HTML construction in JavaScript client library:
Add explicit permissions to GitHub Actions workflows:
These changes follow the principle of least privilege and address all CodeQL security warnings for Flask debug mode, unsafe HTML construction, and missing workflow permissions.