Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 88.24% 88.25% +0.01%
==========================================
Files 108 108
Lines 12207 12221 +14
Branches 2256 2256
==========================================
+ Hits 10772 10786 +14
Misses 904 904
Partials 531 531 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericpre
force-pushed
the
lazy_loading_pantarhei
branch
2 times, most recently
from
8bddcc7 to
2cea284
Compare
ericpre
force-pushed
the
lazy_loading_pantarhei
branch
from
2cea284 to
b3ec05d
Compare
|
@ericpre happy to review! |
Member
Author
|
@tensionhead, please go ahead. There are some information about "distributed memory mapping" in https://hyperspy.org/rosettasciio/user_guide/lazy.html#distributed-loading. |
|
@ericpre I can't assign myself as reviewer it seems |
Member
Author
|
We don't use the assign feature of GitHub, and you can simply go to the "Files changes" tab to add comments on the code and submit your review: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tensionhead, @gguzzina when reviewing #459, I thought it would be a good time to adding lazy support compatible with the dask distributed scheduler, that is not the case of the numpy memory-map functionality. Do you want to review this PR, please?
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:rosettasciiobuild of this PR (link in github checks)