Add generic api's for filtering, pagination in getAllConfigs call #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config-service-api/src/main/proto/org/hypertrace/config/service/v1/config_service.proto
Outdated
Show resolved
Hide resolved
config-service-api/src/main/proto/org/hypertrace/config/service/v1/config_service.proto
Outdated
Show resolved
Hide resolved
config-service-api/src/main/proto/org/hypertrace/config/service/v1/config_service.proto
Outdated
Show resolved
Hide resolved
Contributor
|
lgtm |
Contributor
Author
|
@aaron-steinfeld any idea how to fix trivy scanner version ? |
Contributor
Raised hypertrace/github-actions#76 |
Contributor
Author
|
Still failing with Error: Path does not exist: ''trivy-results.sarif'' |
Contributor
OK this time I tested it :) hypertrace/github-actions#77 |
Contributor
Author
|
Thanks @aaron-steinfeld for the help. please approve |
Contributor
|
@pavan-traceable we don't want to merge this until the implementations are added. There's no benefit to exposing unimplemented API changes. |
Contributor
Author
|
Api's were merged as part of implementation PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add filtering, sorting and pagination support for GetAllConfigs api in generic layer of config service