Skip to content

chore: add NullNode case while converting values for mertrics reporting #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanket-mundra merged 1 commit into from
Apr 24, 2025
Merged

chore: add NullNode case while converting values for mertrics reporting #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rc/main/java/org/hypertrace/core/documentstore/metric/BaseDocStoreMetricProviderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@
return String.valueOf(jsonNode.numberValue());
case BOOLEAN:
return String.valueOf(jsonNode.booleanValue());
case NULL:
return NULL_LABEL_VALUE_PLACEHOLDER;

Check warning on line 144 in document-store/src/main/java/org/hypertrace/core/documentstore/metric/BaseDocStoreMetricProviderImpl.java

View check run for this annotation

Codecov / codecov/patch

document-store/src/main/java/org/hypertrace/core/documentstore/metric/BaseDocStoreMetricProviderImpl.java#L144 

Added line #L144 was not covered by tests
default:
throw new IllegalArgumentException(
String.format("Unsupported JSON node type: %s", jsonNode.getNodeType()));
Expand Down
Loading