Skip to content

Support hyphen in identifier names #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support hyphen in identifier names #246

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6606afb
Support hyphen in identifier names
suddendust Oct 30, 2025
87dfdb3
Fix failing test
suddendust Oct 30, 2025
c2324bc
Fix failing test
suddendust Oct 30, 2025
be03d75
WIP
suddendust Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/org/hypertrace/core/documentstore/postgres/utils/BasicPostgresSecurityValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class BasicPostgresSecurityValidator implements PostgresSecurityValidator
* Documentation</a>
*/
private static final String DEFAULT_IDENTIFIER_PATTERN =
"^[a-zA-Z_][a-zA-Z0-9_]*(\\.[a-zA-Z_][a-zA-Z0-9_]*)*$";
"^[a-zA-Z_][a-zA-Z0-9_-]*(\\.[a-zA-Z_][a-zA-Z0-9_-]*)*$";

/**
* Default pattern for JSON field names within JSONB columns.
Expand Down
12 changes: 5 additions & 7 deletions .../java/org/hypertrace/core/documentstore/postgres/utils/PostgresSecurityValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ void testValidIdentifierWithNumbers() {
assertDoesNotThrow(() -> validator.validateIdentifier("col_1"));
}

@Test
void testValidIdentifierWithHyphens() {
assertDoesNotThrow(() -> validator.validateIdentifier("API.repo-url"));
}

@Test
void testInvalidIdentifierNull() {
SecurityException ex =
Expand Down Expand Up @@ -75,13 +80,6 @@ void testInvalidIdentifierSqlInjection_Semicolon() {
assertTrue(ex.getMessage().contains("invalid"));
}

@Test
void testInvalidIdentifierHyphen() {
SecurityException ex =
assertThrows(SecurityException.class, () -> validator.validateIdentifier("field-name"));
assertTrue(ex.getMessage().contains("invalid"));
}

@Test
void testValidIdentifierWithDotNotation() {
assertDoesNotThrow(() -> validator.validateIdentifier("field.name"));
Expand Down
Loading