Skip to content

Log failed PG queries #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suresh-prakash merged 5 commits into from
Dec 3, 2025
Merged

Log failed PG queries #255

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e847377
Add error log for SQLExceptions
suddendust Dec 3, 2025
72ddf90
Revert "Add error log for SQLExceptions"
suddendust Dec 3, 2025
371ca74
Reapply "Add error log for SQLExceptions"
suddendust Dec 3, 2025
ecafc42
Don't auto-close preparedstatement
suddendust Dec 3, 2025
1ba27c3
Spotless
suddendust Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ...store/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresQueryExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,25 @@ static org.hypertrace.core.documentstore.query.Query transformAndLog(
protected ResultSet execute(final Connection connection, PostgresQueryParser queryParser)
throws SQLException {
final String sqlQuery = queryParser.parse();
final PreparedStatement preparedStatement =
buildPreparedStatement(sqlQuery, queryParser.getParamsBuilder().build(), connection);
log.debug("Executing executeQueryV1 sqlQuery:{}", preparedStatement.toString());
return preparedStatement.executeQuery();
final Params params = queryParser.getParamsBuilder().build();
// this is closed when the corresponding ResultSet is closed in the iterators
PreparedStatement preparedStatement = buildPreparedStatement(sqlQuery, params, connection);
try {
log.debug("Executing SQL query: {}", sqlQuery);
return preparedStatement.executeQuery();
} catch (SQLException e) {
log.error(
"SQL execution failed. Query: {}, SQLState: {}, ErrorCode: {}",
sqlQuery,
e.getSQLState(),
e.getErrorCode(),
e);
throw e;
}
}

public PreparedStatement buildPreparedStatement(
String sqlQuery, Params params, Connection connection) throws SQLException, RuntimeException {
String sqlQuery, Params params, Connection connection) throws SQLException {
PreparedStatement preparedStatement = connection.prepareStatement(sqlQuery);
enrichPreparedStatementWithParams(preparedStatement, params);
return preparedStatement;
Expand Down
Loading