Skip to content

Fix trivy #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 3 commits into from
Apr 9, 2025
Merged

Fix trivy #77

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca838b5
ci: debug
aaron-steinfeld Apr 9, 2025
299901c
fix: again
aaron-steinfeld Apr 9, 2025
88d4b81
fix: clean up debug
aaron-steinfeld Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trivy-image-scan/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ runs:
TRIVY_OUTPUT=""
if [ "${{ inputs.output-mode }}" = "github" ]; then
TRIVY_FORMAT="sarif"
TRIVY_OUTPUT="''trivy-results.sarif''"
TRIVY_OUTPUT="trivy-results.sarif"
Copy link
Contributor Author

@aaron-steinfeld aaron-steinfeld Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall why this had the weird quoting but it seems to be breaking it now and there were no notes in the original PR. Verified it works with this fix in hypertrace/config-service#285

elif [ "${{ inputs.output-mode }}" = "json" ]; then
TRIVY_FORMAT="json"
TRIVY_OUTPUT="trivy-results.json"
Expand Down